llunak added a comment. In D69585#1942431 <https://reviews.llvm.org/D69585#1942431>, @rsmith wrote:
> This needs to be done behind a flag. It's an explicit design goal that > compilation behavior using a PCH or precompiled preamble behaves identically > to compilation not using a PCH / precompiled preamble. The behavior of this > patch is also non-conforming: we're only allowed to perform function template > instantiations at their points of instantiation (essentially, at points of > use + at the end of the translation unit). How is that different from -fmodules? Given that AFAICT this makes PCHs work the same way as modules, this should mean -fmodules also both fails the identical behaviour goal and is non-conforming. And to make sure I understand correctly, by behaving identically you mean that all the compiler output should be identical without even benign differences? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
