MyDeveloperDay added a comment.


> Ok, I've got an idea to deprecate the AfterExternBlock option and map it to a 
> new option

Really? can't you just model IndentExternBlock as an enum? then say

  bool shouldIndent = Style.IndentExternBlock==Indented ||
                                    ( AfterExternBlock && 
Style.IndentExternBlock==NotSpecified)
  
  parseBlock(/*MustBeDeclaration=*/true,
          /*AddLevel=*/shouldIndent);

You can even keep "true" and "false" the the enumeration marshaller and you 
don't even have to change the documentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to