baloghadamsoftware added a comment.

In D77229#2005042 <https://reviews.llvm.org/D77229#2005042>, @NoQ wrote:

> > no crashes but 130 of 550 analyzer tests failing.
>
> You most likely need to fill in the reachibility and liveness code with the 
> behavior of the new region. I don't seem to see it in your current code but 
> their default behavior is clearly incorrect; instead, they should behave 
> exactly like the old region used to.


That sound a lot of code duplication for me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77229/new/

https://reviews.llvm.org/D77229



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to