xazax.hun added a comment.
Overall the changes look good to me here. I had a small nit inline. But I
wonder if we actually should add more code in the analyzer core to better model
the sizes of memory regions corresponding to the VLAs.
================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:576
ExplodedNodeSet &Dst) {
+ if (isa<TypedefNameDecl>(*DS->decl_begin())) {
+ ExplodedNodeSet DstPre;
----------------
At first, it might be confusing why do we need to handle typedefs at all. I
think it might worth adding a comment about VLAs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79072/new/
https://reviews.llvm.org/D79072
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
