balazske marked 3 inline comments as done.
balazske added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:577
+  if (isa<TypedefNameDecl>(*DS->decl_begin())) {
+    ExplodedNodeSet DstPre;
+    getCheckerManager().runCheckersForPreStmt(DstPre, Pred, DS, *this);
----------------
Should we not do something else with the VLA size expressions (not only call 
the checker callbacks) because they should be evaluated, are these handled in 
some other way automatically? (The CFG should contain these expressions already 
so these should be evaluated by the engine, and this place is only to make the 
checkers aware of `typedef` statements.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79072/new/

https://reviews.llvm.org/D79072



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to