Xiangling_L added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4684
return false;
case CodeGenOptions::SRCK_InRegs: // -msvr4-struct-return
return true;
----------------
jasonliu wrote:
> Xiangling_L wrote:
> > I noticed that in patch https://reviews.llvm.org/D76360, Zarko added a
> > check to emit an error for using this option within cc1. But in your patch,
> > this option only emit error when invoked by the driver. Does that mean we
> > are pretty sure this option is doing what we want on AIX?
> Are you able to set this CodeGen option when it is disabled in the
> Frontend/CompilerInvocation.cpp?
I would say if you disable it in this function
`PPC32TargetCodeGenInfo::isStructReturnInRegABI`, neither driver and FE can
invoke it. However, in your patch, the option is disabled only in the driver,
that means you can still invoke it with clang_cc1.
================
Comment at: clang/test/CodeGen/aix-vector.c:11
+}
+
----------------
Please remove the extra blank line
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79035/new/
https://reviews.llvm.org/D79035
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
