stuij marked 2 inline comments as done. stuij added a comment. @asmith: Thanks for reviewing :) Fixed your suggestions in the coming revision.
================ Comment at: clang/include/clang/AST/ASTContext.h:965 CanQualType HalfTy; // [OpenCL 6.1.1.1], ARM NEON + CanQualType BFloat16Ty; // ARM NEON CanQualType Float16Ty; // C11 extension ISO/IEC TS 18661-3 ---------------- asmith wrote: > Maybe the comment is unnecessary. I can imagine other targets besides ARM > NEON using BFloat fair ================ Comment at: clang/include/clang/AST/Type.h:1982 bool isFloat16Type() const; // C11 extension ISO/IEC TS 18661 + bool isBFloat16Type() const; // ARM BFloat bool isFloat128Type() const; ---------------- asmith wrote: > don't think this comment adds anything > fair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
