majnemer added inline comments.
================
Comment at: clang/include/clang-c/Index.h:3254
CXType_FirstBuiltin = CXType_Void,
CXType_LastBuiltin = CXType_ULongAccum,
----------------
Should this be:
CXType_LastBuiltin = CXType_BFloat16,
================
Comment at: clang/lib/AST/ItaniumMangle.cpp:3186
+ case BuiltinType::Half: EltName = "float16_t"; break;
+ case BuiltinType::BFloat16: EltName = "bfloat16x1_t"; break;
default:
----------------
Why is this x1?
================
Comment at: clang/lib/Sema/SemaOverload.cpp:1873-1874
// We of course allow this conversion if long double is really double.
+ if (FromType == S.Context.BFloat16Ty || ToType == S.Context.BFloat16Ty)
+ return false;
if (&S.Context.getFloatTypeSemantics(FromType) !=
----------------
This probably needs an explanation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76077/new/
https://reviews.llvm.org/D76077
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
