kbobyrev updated this revision to Diff 278237.
kbobyrev marked 5 inline comments as done.
kbobyrev added a comment.
Resolve the comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83831/new/
https://reviews.llvm.org/D83831
Files:
clang-tools-extra/clangd/index/remote/Client.cpp
clang-tools-extra/clangd/index/remote/server/Server.cpp
Index: clang-tools-extra/clangd/index/remote/server/Server.cpp
===================================================================
--- clang-tools-extra/clangd/index/remote/server/Server.cpp
+++ clang-tools-extra/clangd/index/remote/server/Server.cpp
@@ -9,6 +9,8 @@
#include "index/Index.h"
#include "index/Serialization.h"
#include "index/remote/marshalling/Marshalling.h"
+#include "support/Logger.h"
+#include "support/Trace.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/Path.h"
@@ -35,6 +37,16 @@
llvm::cl::opt<std::string> IndexRoot(llvm::cl::desc("<PROJECT ROOT>"),
llvm::cl::Positional, llvm::cl::Required);
+llvm::cl::opt<std::string> TracerFile(
+ "tracer-file",
+ llvm::cl::desc("Path to the file where tracer logs will be stored"));
+
+llvm::cl::opt<bool> PrettyPrint{
+ "pretty",
+ llvm::cl::desc("Pretty-print JSON output"),
+ llvm::cl::init(true),
+};
+
llvm::cl::opt<std::string> ServerAddress(
"server-address", llvm::cl::init("0.0.0.0:50051"),
llvm::cl::desc("Address of the invoked server. Defaults to 0.0.0.0:50051"));
@@ -57,21 +69,32 @@
grpc::Status Lookup(grpc::ServerContext *Context,
const LookupRequest *Request,
grpc::ServerWriter<LookupReply> *Reply) override {
+ trace::Span Tracer("LookupRequest");
+ SPAN_ATTACH(Tracer, "Request", Request->DebugString());
clangd::LookupRequest Req;
for (const auto &ID : Request->ids()) {
auto SID = SymbolID::fromStr(StringRef(ID));
- if (!SID)
+ if (!SID) {
+ elog("Lookup request cancelled: invalid SymbolID {1}", SID.takeError());
return grpc::Status::CANCELLED;
+ }
Req.IDs.insert(*SID);
}
+ unsigned Sent = 0;
+ unsigned FailedToSend = 0;
Index->lookup(Req, [&](const clangd::Symbol &Sym) {
auto SerializedSymbol = toProtobuf(Sym, IndexedProjectRoot);
- if (!SerializedSymbol)
+ if (!SerializedSymbol) {
+ ++FailedToSend;
return;
+ }
LookupReply NextMessage;
*NextMessage.mutable_stream_result() = *SerializedSymbol;
Reply->Write(NextMessage);
+ ++Sent;
});
+ SPAN_ATTACH(Tracer, "Sent", Sent);
+ SPAN_ATTACH(Tracer, "Failed to send", FailedToSend);
LookupReply LastMessage;
LastMessage.set_final_result(true);
Reply->Write(LastMessage);
@@ -81,15 +104,24 @@
grpc::Status FuzzyFind(grpc::ServerContext *Context,
const FuzzyFindRequest *Request,
grpc::ServerWriter<FuzzyFindReply> *Reply) override {
+ trace::Span Tracer("FuzzyFind");
+ SPAN_ATTACH(Tracer, "Request", Request->DebugString());
const auto Req = fromProtobuf(Request, IndexedProjectRoot);
+ unsigned Sent = 0;
+ unsigned FailedToSend = 0;
bool HasMore = Index->fuzzyFind(Req, [&](const clangd::Symbol &Sym) {
auto SerializedSymbol = toProtobuf(Sym, IndexedProjectRoot);
- if (!SerializedSymbol)
+ if (!SerializedSymbol) {
+ ++FailedToSend;
return;
+ }
FuzzyFindReply NextMessage;
*NextMessage.mutable_stream_result() = *SerializedSymbol;
Reply->Write(NextMessage);
+ ++Sent;
});
+ SPAN_ATTACH(Tracer, "Sent", Sent);
+ SPAN_ATTACH(Tracer, "Failed to send", FailedToSend);
FuzzyFindReply LastMessage;
LastMessage.set_final_result(HasMore);
Reply->Write(LastMessage);
@@ -98,21 +130,32 @@
grpc::Status Refs(grpc::ServerContext *Context, const RefsRequest *Request,
grpc::ServerWriter<RefsReply> *Reply) override {
+ trace::Span Tracer("Refs");
+ SPAN_ATTACH(Tracer, "Request", Request->DebugString());
clangd::RefsRequest Req;
for (const auto &ID : Request->ids()) {
auto SID = SymbolID::fromStr(StringRef(ID));
- if (!SID)
+ if (!SID) {
+ elog("Refs request cancelled: invalid SymbolID {1}", SID.takeError());
return grpc::Status::CANCELLED;
+ }
Req.IDs.insert(*SID);
}
+ unsigned Sent = 0;
+ unsigned FailedToSend = 0;
bool HasMore = Index->refs(Req, [&](const clangd::Ref &Reference) {
auto SerializedRef = toProtobuf(Reference, IndexedProjectRoot);
- if (!SerializedRef)
+ if (!SerializedRef) {
+ ++FailedToSend;
return;
+ }
RefsReply NextMessage;
*NextMessage.mutable_stream_result() = *SerializedRef;
Reply->Write(NextMessage);
+ ++Sent;
});
+ SPAN_ATTACH(Tracer, "Sent", Sent);
+ SPAN_ATTACH(Tracer, "Failed to send", FailedToSend);
RefsReply LastMessage;
LastMessage.set_final_result(HasMore);
Reply->Write(LastMessage);
@@ -147,6 +190,29 @@
llvm::cl::ParseCommandLineOptions(argc, argv, Overview);
llvm::sys::PrintStackTraceOnErrorSignal(argv[0]);
+ llvm::Optional<llvm::raw_fd_ostream> TracerStream;
+ std::unique_ptr<clang::clangd::trace::EventTracer> Tracer;
+ if (!TracerFile.empty()) {
+ std::error_code EC;
+ TracerStream.emplace(TracerFile, EC,
+ llvm::sys::fs::FA_Read | llvm::sys::fs::FA_Write);
+ if (EC) {
+ TracerStream.reset();
+ llvm::errs() << "Error while opening trace file " << TracerFile << ": "
+ << EC.message();
+ } else {
+ // FIXME(kirillbobyrev): Also create metrics tracer to track latency and
+ // accumulate other request statistics.
+ Tracer =
+ clang::clangd::trace::createJSONTracer(*TracerStream, PrettyPrint);
+ llvm::outs() << "Successfully created a tracer.\n";
+ }
+ }
+
+ llvm::Optional<clang::clangd::trace::Session> TracingSession;
+ if (Tracer)
+ TracingSession.emplace(*Tracer);
+
if (!llvm::sys::path::is_absolute(IndexRoot)) {
llvm::outs() << "Index root should be an absolute path.\n";
return -1;
Index: clang-tools-extra/clangd/index/remote/Client.cpp
===================================================================
--- clang-tools-extra/clangd/index/remote/Client.cpp
+++ clang-tools-extra/clangd/index/remote/Client.cpp
@@ -47,6 +47,7 @@
bool FinalResult = false;
trace::Span Tracer(RequestT::descriptor()->name());
const auto RPCRequest = serializeRequest<ClangdRequestT, RequestT>(Request);
+ SPAN_ATTACH(Tracer, "Request", RPCRequest.DebugString());
grpc::ClientContext Context;
std::chrono::system_clock::time_point Deadline =
std::chrono::system_clock::now() + DeadlineWaitingTime;
@@ -55,6 +56,8 @@
llvm::BumpPtrAllocator Arena;
llvm::UniqueStringSaver Strings(Arena);
ReplyT Reply;
+ unsigned Received = 0;
+ unsigned FailedToParse = 0;
while (Reader->Read(&Reply)) {
if (!Reply.has_stream_result()) {
FinalResult = Reply.final_result();
@@ -64,11 +67,15 @@
fromProtobuf(Reply.stream_result(), &Strings, ProjectRoot);
if (!Response) {
elog("Received invalid {0}", ReplyT::descriptor()->name());
+ ++FailedToParse;
continue;
}
Callback(*Response);
+ ++Received;
}
- SPAN_ATTACH(Tracer, "status", Reader->Finish().ok());
+ SPAN_ATTACH(Tracer, "Status", Reader->Finish().ok());
+ SPAN_ATTACH(Tracer, "Received", Received);
+ SPAN_ATTACH(Tracer, "Failed to parse", FailedToParse);
return FinalResult;
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
