kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:63
+ trace::Span Tracer("Remote index server Lookup");
+ SPAN_ATTACH(Tracer, "LookupRequest", Request->ShortDebugString());
clangd::LookupRequest Req;
----------------
sammccall wrote:
> sammccall wrote:
> > you don't do this on the client side, but could
> prefer DebugString over ShortDebugString, the missing newlines can make it
> hard to follow
Do you mean logging `RPCRequest` there? Done now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83831/new/
https://reviews.llvm.org/D83831
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
