NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

I think this looks great!

P.S. I unforgot why we won't be able to remove the option after all. That's 
because when we partially evalCall and partially inline, inlining breaks. Like, 
once we evalCalled a single method call, we can no longer trust RegionStore to 
have the right data inside of it on the current path, so further inlining 
cannot work correctly. We could forbid inlining and resort to conservative 
evaluation but that'd still be a regression compared to inlining. So i'd rather 
keep the option for as long as possible :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83836/new/

https://reviews.llvm.org/D83836



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to