NoQ added a comment.

Aha, ok, sounds like the right thing to do. Like, for Z3 it's actually the 
wrong thing to do (you'd prefer to evaluate the cast perfectly by adding 
`SymbolCast`) but for pure RangeConstraintManager this is the lesser of two 
evils.

Because this patch changes the behavior of regular analysis (without Z3), i 
expect tests to reflect that. Please add `ExprInspection`-based tests to test 
values produced by casts.

I don't understand why should the behavior be different for incomplete types. 
Can you explain?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85528/new/

https://reviews.llvm.org/D85528

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to