xazax.hun added a comment.
Looks reasonable to me, but I am not very familiar with the impacts of the
additional casts. Do we lose some modeling power when we are using the regular
constraint solver?
For example, when we have constraints both on the original and the cased symbol
can the analyzer "merge" them?
Something like:
ScopedPrimitive sym = conjure<ScopedPrimitive>();
if (sym == ScopedPrimitive::Max)
return;
int sym2 = static_cast<unsigned char>(sym);
if (sym2 == 0)
return;
// Do we know here that both sym and sym2 has the same range?
// Is there a change in the behavior compared to before the patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85528/new/
https://reviews.llvm.org/D85528
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
