bc-lee added inline comments.
================ Comment at: clang/docs/ClangFormatStyleOptions.rst:2027 + + .. code-block:: java + true: ---------------- MyDeveloperDay wrote: > The ClangFormatStyleOptions.rst is generated using > doc/tools/dump_format_style.py which reads Format.h and generates this, > > If this code block in not in the Format.h it will get removed the next time > the script is run, please don't change ClangFormatStyleOption.rst by hand use > the script, so add the code block to the Format.h file (see others options > for now to do this) Done. ================ Comment at: clang/include/clang/Format/Format.h:1705 + /// \endcode + bool JavaStaticImportAfterImport; + ---------------- JakeMerdichAMD wrote: > 3 things here: > > 1. Did you mix up the true and false cases? > 2. (nit) You should also note that if this option is false, all static > imports are before all non-static imports (as opposed to mixed together > alphabetically). I was confused on first glance. > 3. Please add this config option to FormatTests.cpp:ParsesConfigurationBools. I understand. The description is somewhat misleading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
