JakeMerdichAMD added inline comments.
================ Comment at: clang/include/clang/Format/Format.h:1705 + /// \endcode + bool JavaStaticImportAfterImport; + ---------------- bc-lee wrote: > JakeMerdichAMD wrote: > > 3 things here: > > > > 1. Did you mix up the true and false cases? > > 2. (nit) You should also note that if this option is false, all static > > imports are before all non-static imports (as opposed to mixed together > > alphabetically). I was confused on first glance. > > 3. Please add this config option to > > FormatTests.cpp:ParsesConfigurationBools. > I understand. The description is somewhat misleading. New phrasing makes it clear, but true and false are still inverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits