eastig added a comment.

In D31413#2277133 <https://reviews.llvm.org/D31413#2277133>, @ldionne wrote:

> In D31413#2277118 <https://reviews.llvm.org/D31413#2277118>, @eastig wrote:
>
>> In D31413#2277070 <https://reviews.llvm.org/D31413#2277070>, @ldionne wrote:
>>
>>> Added a test. I can't reproduce the issue, so I don't know whether the test 
>>> is useful or not. Please help with that!
>>
>> There are tests in https://reviews.llvm.org/D12689 .
>
> Oh, nice, I missed that. I'll borrow those if you don't mind. Can you close 
> https://reviews.llvm.org/D12689 and leave a trace to this review? I'm trying 
> to de-tangle things here.

I don't mind.
Just to check,  in PR28954 it is mentioned the solution based on 
'init_priority' works for Linux. What about other platforms?
The idea was to fall back to the conservative method if the attribute is not 
supported by a compiler. Maybe, as an option a warning can be issued.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D31413/new/

https://reviews.llvm.org/D31413

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to