aaron.ballman added inline comments.

================
Comment at: clang/include/clang/Basic/Attr.td:384
 
+def ExcludeTarget : TargetSpec {
+  let CustomCode = [{ !Target.getTriple().isOSzOS() }];
----------------
This is not a very descriptive name -- if this is only supposed to be used for 
`init_priority` how about `TargetSupportsInitPriority` instead?

Also, this change is missing test coverage and documentation changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91565/new/

https://reviews.llvm.org/D91565

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to