zibi marked an inline comment as done.
zibi added inline comments.
================
Comment at: clang/include/clang/Basic/Attr.td:384
+def ExcludeTarget : TargetSpec {
+ let CustomCode = [{ !Target.getTriple().isOSzOS() }];
----------------
aaron.ballman wrote:
> This is not a very descriptive name -- if this is only supposed to be used
> for `init_priority` how about `TargetSupportsInitPriority` instead?
>
> Also, this change is missing test coverage and documentation changes.
For now, we can use `TargetSupportsInitPriority`, we can always change it if we
find the need to disable other attributes.
Thank you Arraon for review and suggestion for the name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91565/new/
https://reviews.llvm.org/D91565
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
