jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
LG after fixing the minor nits.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6377
+ } else {
+ CmdArgs.push_back("-target-feature");
+ CmdArgs.push_back("-outline-atomics");
----------------
We don't usually explicitly use negative features like this, do we? I think
this else clause can be omitted.
================
Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:492-495
+#define LCALL4(A)
\
+ LCALLS(A, 1), LCALLS(A, 2), LCALLS(A, 4), LCALLS(A, 8), {
\
+ UNKNOWN_LIBCALL, UNKNOWN_LIBCALL, UNKNOWN_LIBCALL, UNKNOWN_LIBCALL
\
+ }
----------------
As with the .def file, get rid of LCALL4, and just use LCALL5 for everything
here. AArch64ISelLowering won't setup libcall names for 128-bit ones, which is
fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91157/new/
https://reviews.llvm.org/D91157
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
