ilinpv added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6377
+ } else {
+ CmdArgs.push_back("-target-feature");
+ CmdArgs.push_back("-outline-atomics");
----------------
jyknight wrote:
> We don't usually explicitly use negative features like this, do we? I think
> this else clause can be omitted.
We do, -soft-float for example in Clang.cpp:2397
```
if (Value.startswith("-mhard-float")) {
CmdArgs.push_back("-target-feature");
CmdArgs.push_back("-soft-float");
continue;
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91157/new/
https://reviews.llvm.org/D91157
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
