kbobyrev added a comment. Actually, it would be safer if `FindGRPC` was also higher than `add_subdirectory(tool)`: right now it only includes `remote/index/Client.h` and `Client.h` does not depend on any gRPC/Protobuf headers for now but that might change at some point and break builds unexpectedly. I would suggest just moving it as high as possible, there is no harm in that apart from decoupling `FindGRPC` from `add_subdirectory(index/remote)` and related code but we kind of have to do that anyway.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91859/new/ https://reviews.llvm.org/D91859 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
