kadircet updated this revision to Diff 306830.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91859/new/
https://reviews.llvm.org/D91859
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/remote/CMakeLists.txt
clang-tools-extra/clangd/unittests/CMakeLists.txt
Index: clang-tools-extra/clangd/unittests/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/unittests/CMakeLists.txt
+++ clang-tools-extra/clangd/unittests/CMakeLists.txt
@@ -143,7 +143,8 @@
if (CLANGD_ENABLE_REMOTE)
target_link_libraries(ClangdTests
PRIVATE
- clangdRemoteMarshalling)
+ clangdRemoteMarshalling
+ RemoteIndexProto)
endif()
if (CLANGD_BUILD_XPC)
Index: clang-tools-extra/clangd/index/remote/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/CMakeLists.txt
@@ -3,6 +3,12 @@
generate_protos(RemoteIndexServiceProto "Service.proto"
DEPENDS "Index.proto"
GRPC)
+ # FIXME: Move this into generate_protos. Currently we only mention proto
+ # filename as a dependency, but linking requires target name.
+ target_link_libraries(RemoteIndexServiceProto
+ PRIVATE
+ RemoteIndexProto
+ )
include_directories(${CMAKE_CURRENT_BINARY_DIR})
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../../)
@@ -20,6 +26,8 @@
clangdRemoteMarshalling
protobuf
grpc++
+ clangBasic
+ clangDaemon
clangdSupport
DEPENDS
Index: clang-tools-extra/clangd/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/CMakeLists.txt
+++ clang-tools-extra/clangd/CMakeLists.txt
@@ -167,17 +167,18 @@
add_subdirectory(xpc)
endif ()
+if (CLANGD_ENABLE_REMOTE)
+ include(FindGRPC)
+endif()
+
if(CLANG_INCLUDE_TESTS)
-add_subdirectory(test)
-add_subdirectory(unittests)
+ add_subdirectory(test)
+ add_subdirectory(unittests)
endif()
# FIXME(kirillbobyrev): Document this in the LLVM docs once remote index is
stable.
option(CLANGD_ENABLE_REMOTE "Use gRPC library to enable remote index support
for Clangd" OFF)
set(GRPC_INSTALL_PATH "" CACHE PATH "Path to gRPC library manual
installation.")
-if (CLANGD_ENABLE_REMOTE)
- include(FindGRPC)
-endif()
add_subdirectory(index/remote)
add_subdirectory(index/dex/dexp)
Index: clang-tools-extra/clangd/unittests/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/unittests/CMakeLists.txt
+++ clang-tools-extra/clangd/unittests/CMakeLists.txt
@@ -143,7 +143,8 @@
if (CLANGD_ENABLE_REMOTE)
target_link_libraries(ClangdTests
PRIVATE
- clangdRemoteMarshalling)
+ clangdRemoteMarshalling
+ RemoteIndexProto)
endif()
if (CLANGD_BUILD_XPC)
Index: clang-tools-extra/clangd/index/remote/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/CMakeLists.txt
@@ -3,6 +3,12 @@
generate_protos(RemoteIndexServiceProto "Service.proto"
DEPENDS "Index.proto"
GRPC)
+ # FIXME: Move this into generate_protos. Currently we only mention proto
+ # filename as a dependency, but linking requires target name.
+ target_link_libraries(RemoteIndexServiceProto
+ PRIVATE
+ RemoteIndexProto
+ )
include_directories(${CMAKE_CURRENT_BINARY_DIR})
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../../)
@@ -20,6 +26,8 @@
clangdRemoteMarshalling
protobuf
grpc++
+ clangBasic
+ clangDaemon
clangdSupport
DEPENDS
Index: clang-tools-extra/clangd/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/CMakeLists.txt
+++ clang-tools-extra/clangd/CMakeLists.txt
@@ -167,17 +167,18 @@
add_subdirectory(xpc)
endif ()
+if (CLANGD_ENABLE_REMOTE)
+ include(FindGRPC)
+endif()
+
if(CLANG_INCLUDE_TESTS)
-add_subdirectory(test)
-add_subdirectory(unittests)
+ add_subdirectory(test)
+ add_subdirectory(unittests)
endif()
# FIXME(kirillbobyrev): Document this in the LLVM docs once remote index is stable.
option(CLANGD_ENABLE_REMOTE "Use gRPC library to enable remote index support for Clangd" OFF)
set(GRPC_INSTALL_PATH "" CACHE PATH "Path to gRPC library manual installation.")
-if (CLANGD_ENABLE_REMOTE)
- include(FindGRPC)
-endif()
add_subdirectory(index/remote)
add_subdirectory(index/dex/dexp)
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
