serge-sans-paille added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010 + + if (!EffectiveTriple.isOSLinux()) + return; + ---------------- emaste wrote: > Is there anything OS-dependent here? > > I plan to add `EffectiveTriple.isOSFreeBSD()` to FreeBSD-s in-tree Clang > https://reviews.freebsd.org/D27366 > and intend to upstream the change (with a test), but should we just remove > the OS test completely? According to https://blog.qualys.com/vulnerabilities-research/2017/06/19/the-stack-clash, stack clash impacts > Linux, OpenBSD, NetBSD, FreeBSD and Solaris We should probably enlarge the test to these platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
