vsk added inline comments.

================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:851
+        return "csllvm";
+      default:
+        llvm_unreachable("unknown instrumentation type");
----------------
If we add an instrumentation kind, it may be more convenient to trigger a 
-Wcovered-switch warning (by removing this default case) vs. seeing a crash at 
runtime.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94820/new/

https://reviews.llvm.org/D94820

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to