phosek marked an inline comment as done.
phosek added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:851
+ return "csllvm";
+ default:
+ llvm_unreachable("unknown instrumentation type");
----------------
vsk wrote:
> If we add an instrumentation kind, it may be more convenient to trigger a
> -Wcovered-switch warning (by removing this default case) vs. seeing a crash
> at runtime.
Done, I've also decided to move the helper function inside the `ProfileList`
class to hide the detail of how `ProfileInstrKind` translates to section name.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94820/new/
https://reviews.llvm.org/D94820
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
