SjoerdMeijer added a comment.
In D93585#2526774 <https://reviews.llvm.org/D93585#2526774>, @ilinpv wrote:
> Clang driver tests for outline atomics were added.
Thanks!
Is there a way we can test `-rtlib=libgcc`?
================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:855
+ const GCCVersion &Ver = GCCInstallation.getVersion();
+ if (Ver.isOlderThan(9, 3, 1))
+ return false;
----------------
Nit: if we change this into:
if (GCCInstallation.getVersion().isOlderThan(9, 3, 1))
we can get rid of the curly brackets.
================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:857
+ return false;
+ } else if (GetRuntimeLibType(Args) != ToolChain::RLT_CompilerRT) {
+ return false;
----------------
This means we need one more test and RUN line with the rtlib not being
compiler-rt or libgcc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93585/new/
https://reviews.llvm.org/D93585
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
