njames93 added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck -input-file=%T/modernize-concat-nested-namespaces.h %S/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h -check-prefix=CHECK-FIXES +// Restore header file and re-run with c++2b: +// RUN: cp %S/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h %T/modernize-concat-nested-namespaces.h ---------------- DmitryPolukhin wrote: > njames93 wrote: > > Why do we explicitly run on c++2b and not c++20? I understand there is no > > framework in place for using -std=c++17-or-later when header files are > > modified. > There is no good reason, I just took highest current version. Changed to > c++20. This is just me rambling, but i think we should think about introducing a test mode to clang tidy, where fixes can be applied to a test directory and maybe try and make use of the verify diagnostic consumer. The current implementation works, but is very rough round the edges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
