svenvh added a comment.

In D97869#2602943 <https://reviews.llvm.org/D97869#2602943>, @Anastasia wrote:

> I was just thinking if we could combine the calls into one function to 
> minimize the number of lines to parse? Perhaps this will make the Tablegen 
> generator too complex?

That will increase the emitter's complexity.  Especially when taking into 
account the next point about handling optional functionality.  Hard to say in 
advance if paying for the added emitter complexity is worth the parsing time 
reduction, though the parsing time reduction is probably not going to be an 
order of magnitude difference.

> Also would it be possible to handle optional functionality - extensions and 
> functions available in certain versions?

Yes, I think this should be possible; I already have a TODO in the emitter.  It 
will make the resulting file bigger of course, because parts will have to be 
guarded with #ifdefs.  But I believe it would be a good way to test extension 
and version handling for builtins.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97869/new/

https://reviews.llvm.org/D97869

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to