Anastasia added a comment. In D97869#2603249 <https://reviews.llvm.org/D97869#2603249>, @azabaznov wrote:
> That's awesome! > > I'm thinking of how can you track correctness of generated built-ins > according to spec. Perhaps you can compare the number of distinct > declarations for each built-in in the spec and in tablegen and diagnose if > they are not equal. This is a very straightforward, but I can't think of on > other solution yet (with the absence of CTS coverage)... The advantage of adding standard clang testing through the whole frontend invocation is that we can test all of the frontend features together to make sure that they indeed work as expected. For example there are types or macros added by clang and declarations from the `opencl-base-c.h` that interact with the headers declaring builtin functions so I think it would be desirable to use the standard clang testing strategy. There is also another advantage - it is more intuitive for the community to understand and maintain further. But of course simple diffing should be fast I assume. We could look into this if we get push back on the traditional testing or we could consider it as a hybrid approach too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
