MyDeveloperDay requested changes to this revision.
MyDeveloperDay added inline comments.
This revision now requires changes to proceed.
================
Comment at: clang/unittests/Format/FormatTest.cpp:9392
+ "};\n";
+ EXPECT_EQ(NL_B_3_A_1_I_3, format(NL_B_3_A_3_I_3, Style));
+
----------------
I can't read this, I can't tell if you've fat fingered a test, I feel these are
better done systematically one by one with the text in the verifyFormat("...")
it makes it easier when they fail to understand what is going on.
Also its ok to have more than one TEST_F if you want to handle the different
states in small batches
I think you undetersand what NL_B_3_A_0_I_0 means and how it differs form
NL_B_0_A_3_I_0 but others won't
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98237/new/
https://reviews.llvm.org/D98237
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
