MyDeveloperDay added inline comments.
================ Comment at: clang/docs/ClangFormatStyleOptions.rst:2132 +**EmptyLineAfterAccessModifier** (``EmptyLineAfterAccessModifierStyle``) + Defines in which cases to put empty line after access modifiers. + ---------------- ================ Comment at: clang/docs/ClangFormatStyleOptions.rst:2159 + Always add empty line after access modifiers if there are none. + MaxEmptyLinesToKeep is applied also. + ---------------- if MaxEmptyLineToKeep is 0 then surely ELAAMS_Always should win, as this is the lesser i.e. if people never uses extra lines except after access modifiers this is what they would set? did I missunderstand? otherwise doesn't MaxEmptyLinesToKeep just nullify the whole option? meaning its useless for anyone using it? I agree in the ELAAMS_Leave case that MaxEmptyLinesToKeep should win. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
