aaron.ballman added inline comments.

================
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:574
+  std::string PrioritySuffix = llvm::utostr(Priority);
+  // Priority is always <= 65535 (enforced by sema).
+  PrioritySuffix = std::string(6 - PrioritySuffix.size(), '0') + 
PrioritySuffix;
----------------
This isn't quite true -- it's enforced by sema for user code, but not for code 
that identifies itself as a system header. I see that this is existing code 
that's moved around a bit, but we may want to add an assertion here just in 
case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99291/new/

https://reviews.llvm.org/D99291

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to