aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.
Wow these are really a lot of instructions!
================
Comment at: clang/test/Headers/wasm.c:2
+// REQUIRES: webassembly-registered-target
// expected-no-diagnostics
----------------
Now that we have `CHECK` lines, we don't need this
================
Comment at: clang/test/Headers/wasm.c:1060-1069
+// CHECK-LABEL: test_i64x2_abs:
+// CHECK: local.get 0{{$}}
+// CHECK-NEXT: local.get 0{{$}}
+// CHECK-NEXT: i32.const 63{{$}}
+// CHECK-NEXT: i64x2.shr_s{{$}}
+// CHECK-NEXT: local.tee 1{{$}}
+// CHECK-NEXT: i64x2.add{{$}}
----------------
Why can't this be done in a single instruction and what is the `FIXME` for?
Maybe a bit of more explanation would help.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101684/new/
https://reviews.llvm.org/D101684
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
