dblaikie added a comment.

I thought maybe /some/ of the other targets used end-to-end clang tests to test 
intrinsics, but I can't seem to find any (they seem to be a small minority, if 
there are any):

  grep -r -l intrin.h clang/test/ | xargs grep -L emit-llvm.*FileCheck | xargs 
grep RUN | less

(then looking for any RUN lines that use FileCheck but don't use emit-llvm)

Unless there's something really different about WebAssembly here, or some 
evidence that the existing test strategy has been problematic - I think it'd be 
good to stick with this general approach to testing WebAssembly's intrinsics 
too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101684/new/

https://reviews.llvm.org/D101684

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to