OikawaKirie added a comment. > FileCheck error: '<stdin>' is empty.
It fails again on the build bot, another dead end. Maybe I need a Debian server to reproduce the problem encountered in the test case. In D101763#2745918 <https://reviews.llvm.org/D101763#2745918>, @steakhal wrote: > In D101763#2745802 <https://reviews.llvm.org/D101763#2745802>, @OikawaKirie > wrote: > >> I do not know why the test case always fails on the build server, it runs >> perfectly on my computer. : ( > > I've locally run your patch and seemed good to me, I regret not having a look > at the actual build bot. I have tried the test case on a Ubuntu 20.04 server with kernel 5.4.0 and gcc 9.3.0, as well as a CentOS 7 server with kernel 3.10.0 and gcc 7.1.0. Both of them work well. > In D101763#2745900 <https://reviews.llvm.org/D101763#2745900>, @OikawaKirie > wrote: > >> Monitor function `open` together with `openat` to fix the failure in the >> test case. >> As some distros actually call function `open` rather than forward to >> function `openat`, both functions should be monitored by `strace`. >> >> But I am still worrying about whether function `open` will call `openat` and >> vice versa. If this circumstance is possible, the test case may still fail. >> Although, I have not found any pieces of evidence for such invocations. > > Uh, that's a fair point. Now, I'm also worried xD > To be fair, I don't have any better idea testing this without overwhelming > effort. > If anything goes wrong, we can simply revert this change. This is 'just' a > performance fix. I will try to reproduce and fix the problem of the test case next week. If I cannot find other ways to overcome the problem by the next weekend, we can have a try on landing this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101763/new/ https://reviews.llvm.org/D101763 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
