martong added a comment.

First of all, thank you for the patch!
We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in the 
following. This is indeed an issue and the fix is okay. About the test, we'd 
like to ask if you could create a small test lib with its own 'open' function 
that would simply call the system's open and would print 'open'. And then with 
LD_PREOLOAD you could use that lib in the lit test. (If that approach is not 
working for some reason then we may just mark the test with XFAIL.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101763/new/

https://reviews.llvm.org/D101763

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to