NoQ added a comment.

Additionally, `forCallable(functionDecl())` is not equivalent to 
`forFunction()` (the former silently matches less stuff). So anybody who had 
`functionDecl()` spelled out explicitly in their code will observe a silent 
change in behavior. I think that most of the time the difference was a footgun 
(i.e., most of the time when people wrote `forFunction()` they actually 
expected it to behave like `forCallable(functionDecl())`) but I can't be 100% 
sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102213/new/

https://reviews.llvm.org/D102213

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to