NoQ added inline comments.
================ Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7597 +/// but does not match 'int y = 2'. +AST_MATCHER_P(Stmt, forCallable, internal::Matcher<Decl>, InnerMatcher) { + const auto &Parents = Finder->getASTContext().getParents(Node); ---------------- aaron.ballman wrote: > NoQ wrote: > > aaron.ballman wrote: > > > You should also update Registry.cpp to expose this via the dynamic > > > matchers. > > Uh-oh, i knew i was forgetting something! > > > > Do we have a checklist? (Do we want to?) > I don't think we have a checklist, but the mental checklist I use is: > > * If there's a change to doc comments in ASTMatchers.h, did the HTML file get > regenerated? > * If there's a new matcher added, did Registry.cpp get updated for it? > * If there are changes to the list in Registry.cpp, is the list still > alphabetical? > * Testcases? Wait, it's autogenerated? I updated it by hand :D Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits