dmgreen added inline comments.
================ Comment at: llvm/lib/IR/AutoUpgrade.cpp:556 } + if (Name.startswith("aarch64.neon.rbit")) { + NewFn = Intrinsic::getDeclaration(F->getParent(), Intrinsic::bitreverse, ---------------- Do we have a test for the autoupgrade, to show that @llvm.aarch64.neon.rbit turns into @llvm.bitreverse? ================ Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:381 setOperationAction(ISD::BITREVERSE, MVT::i64, Legal); + setOperationAction(ISD::BITREVERSE, MVT::v8i8, Legal); + setOperationAction(ISD::BITREVERSE, MVT::v16i8, Legal); ---------------- Can we move this to the other "hasNeon" section? ================ Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1019 setOperationAction(ISD::CTLZ, MVT::v1i64, Expand); setOperationAction(ISD::CTLZ, MVT::v2i64, Expand); ---------------- Perhaps here. This looks quite neon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102397/new/ https://reviews.llvm.org/D102397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits