aaron.ballman added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278
if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) ==
- SanitizerMask())
+ SanitizerMask() &&
+ SanitizerName != "coverage")
----------------
melver wrote:
> aaron.ballman wrote:
> > The formatting looks rather off here to my eyes, but if this is what
> > clang-format produces for you, then I'm fine with it.
> Yeah, I had something else here, but then clang-format suggested this and I
> don't like it either.
>
> Could remove the /*AllowGroups=*/ bit, for the sake of formatting better?
I'd rather have the comment + ugly formatting than pretty formatting +
mysterious boolean literal, so I'd say let's just leave it as-is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102772/new/
https://reviews.llvm.org/D102772
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
