melver added inline comments.
================ Comment at: clang/test/CodeGen/sanitize-coverage.c:23-87 +static inline __attribute__((__always_inline__)) void always_inlined_fn(int n) { + if (n) + x[n] = 42; +} +// CHECK-LABEL: define dso_local void @test_always_inline( +void test_always_inline(int n) { + // CHECK-DAG: call void @__sanitizer_cov_trace_pc ---------------- vitalybuka wrote: > you are adding tests for unrelated code. > Could you please land is as a separate NFC patch first? Which bits in particular? Just the ``` static inline __attribute__((__always_inline__)) void always_inlined_fn(int n) { if (n) x[n] = 42; } // CHECK-LABEL: define dso_local void @test_always_inline( void test_always_inline(int n) { // CHECK-DAG: call void @__sanitizer_cov_trace_pc // CHECK-DAG: call void @__sanitizer_cov_trace_const_cmp always_inlined_fn(n); } ``` part? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102772/new/ https://reviews.llvm.org/D102772 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits