MaskRay marked 2 inline comments as done. MaskRay added inline comments.
================ Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32 | FileCheck %s -check-prefix=ALIGN_32 + ---------------- jrtc27 wrote: > MaskRay wrote: > > luismarques wrote: > > > Nit: it's a convention of the RISC-V backend codegen tests to wrap the > > > RUN lines. > > only 86 columns. compiler-rt is even transiting to 100 column. > compiler-rt is not the RISC-V backend :) Wrapping lines here just makes the code less readable. ================ Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:13 + +; ALIGN_16-LABEL: test: +; ALIGN_16: .p2align 4 ---------------- jrtc27 wrote: > - not _ in check prefixes I find that `_` in check prefixes is also popular. It has the benefit that `_` cannot conflict with `-NOT` -LABEL` etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106701/new/ https://reviews.llvm.org/D106701 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
