JonChesterfield added inline comments.
================
Comment at: clang/lib/Headers/openmp_wrappers/math.h:53
+#pragma omp begin declare variant match(device = {arch(amdgcn)})
+
+#define __OPENMP_AMDGCN__
----------------
That's quite worrying. Declare variant match amdgcn is supposed to have the
same effect here as the older style macro. I wonder if we have any test
coverage for whether declare variant works for amdgcn.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104904/new/
https://reviews.llvm.org/D104904
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
