LuoYuanke added inline comments.
================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197
+ else if (PatchedName.endswith("sh"))
+ PatchedName = IsVCMP ? "vcmpsh" : "cmpsh";
+ else if (PatchedName.endswith("ph"))
----------------
There is no cmpsh?
================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3199
+ else if (PatchedName.endswith("ph"))
+ PatchedName = IsVCMP ? "vcmpph" : "cmpph";
else
----------------
We only have vcmpph?
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1873
setOperationAction(ISD::SETCC, VT, Custom);
+ setOperationAction(ISD::STRICT_FSETCC, VT, Custom);
+ setOperationAction(ISD::STRICT_FSETCCS, VT, Custom);
----------------
Is this related to FP16?
================
Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:2674
+let Predicates = [HasFP16] in {
+ def : Pat<(v1i1 (X86cmpms(loadf16 addr:$src2), FR16X:$src1,
+ CommutableCMPCC : $cc)),
----------------
X86cmpms (
================
Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:2675
+ def : Pat<(v1i1 (X86cmpms(loadf16 addr:$src2), FR16X:$src1,
+ CommutableCMPCC : $cc)),
+ (VCMPSHZrm FR16X:$src1, addr:$src2, imm:$cc)>;
----------------
CommutableCMPCC:$cc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
