LuoYuanke added inline comments.
================ Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:4838 { X86::VMULSDZrr_Intk, X86::VMULSDZrm_Intk, TB_NO_REVERSE }, + { X86::VMULSHZrr_Intk, X86::VMULSHZrm_Intk, TB_NO_REVERSE }, { X86::VMULSSZrr_Intk, X86::VMULSSZrm_Intk, TB_NO_REVERSE }, ---------------- Is this because intrinsics always assume the arguments are passed in register? ================ Comment at: llvm/test/CodeGen/X86/avx512fp16-fmaxnum.ll:26 +; CHECK: # %bb.0: +; CHECK-NEXT: vmaxph %xmm0, %xmm1, %xmm2 # encoding: [0x62,0xf5,0x74,0x08,0x5f,0xd0] +; CHECK-NEXT: vcmpunordph %xmm0, %xmm0, %k1 # encoding: [0x62,0xf3,0x7c,0x08,0xc2,0xc8,0x03] ---------------- Is it legal without avx512vl? ================ Comment at: llvm/test/CodeGen/X86/avx512fp16-fold-load-binops.ll:7 +; _mm_add_ss(a, _mm_load_ss(b)); + +define <8 x half> @addsh(<8 x half> %va, half* %pb) { ---------------- Any case for max/min? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/ https://reviews.llvm.org/D105264 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits