mkuper added a comment. In http://reviews.llvm.org/D20528#437090, @RKSimon wrote:
> In http://reviews.llvm.org/D20528#436893, @mkuper wrote: > > > This looks right, but we may lose some end-to-end tests, since right now we > > have a clang-level test that checks the builtin is lowered to the > > intrinsic, and (hopefully) a CG-level test that the intrinsic is lowered to > > the correct instruction. > > Do you know if there are already CG tests that check we correctly lower > > these IR patterns to CVTPS2PD, etc? If not, could you add them? > > > I do have the relevant changes for > llvm\test\CodeGen\X86\sse2-intrinsics-fast-isel.ll and > llvm\test\CodeGen\X86\avx-intrinsics-fast-isel.ll (I spent most of last week > adding them all.....). Do you want me to setup a separate llvm patch for > review? I'm not ready to do the rest of the llvm work (removal of the llvm > intrinsics / auto-upgrade etc.). but the fast-isel changes are very simple. Sorry, I didn't intend to imply the rest of the llvm work is necessary for this to go in. Just that I'd be happier with this patch knowing that we have a regression test for doing the (shuffle + fpext, say) lowering correctly. I didn't even mean fast-isel, only the DAG. Repository: rL LLVM http://reviews.llvm.org/D20528 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
