FederAndInk marked an inline comment as done. FederAndInk added inline comments.
================ Comment at: clang/docs/tools/dump_format_style.py:26 +def register_plural(singular: str, plural: str): + if plural not in plurals: ---------------- HazardyKnusperkeks wrote: > FederAndInk wrote: > > MyDeveloperDay wrote: > > > This failed for me with invalid syntax > > Oh, ok, sorry, I might be using to recent python features, I'll remove type > > specifier, what is the recommended python version to use? > > Oh, ok, sorry, I might be using to recent python features, I'll remove type > > specifier, what is the recommended python version to use? > > That **I** can not answer. I run > ```$ python --version > Python 3.9.5 > ``` Ok thanks, this is a reasonably recent version, I think we might want to explicitly specify python3 in the script to avoid using python2, I'll upload the diffs immediately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits