FederAndInk added inline comments.
================ Comment at: clang/docs/tools/dump_format_style.py:21-25 + # To allow testing with an untracked PLURAL_FILE + open(PLURAL_FILE, 'w').close() # TODO: remove this line when review is accepted + # TODO: use check_call when review is accepted + subprocess.call(['git', 'checkout', '--', PLURAL_FILE]) + ---------------- Just to let you know, I've made modifications to be able to test the code with an untracked plurals file. We might want stricter checks by calling check_call instead, also we won't need line 22 above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
