bkramer added inline comments. ================ Comment at: include-fixer/IncludeFixer.h:51 @@ -50,6 +50,3 @@ - /// Headers to be added. - std::set<std::string> &Headers; - - /// Replacements are written here. - std::vector<clang::tooling::Replacement> &Replacements; + /// The context that contains all information about queried symbol. + IncludeFixerContext &Context; ---------------- maybe 'about the symbol being queried'?
================ Comment at: include-fixer/IncludeFixer.h:72 @@ +71,3 @@ + StringRef Code, StringRef FilePath, StringRef FallbackStyle, + unsigned FirstIncludeOffset, const std::string &Header); + ---------------- 'Header' looks like it should be a StringRef too. ================ Comment at: include-fixer/IncludeFixerContext.h:19 @@ +18,3 @@ + +struct IncludeFixerContext { + std::string SymbolIdentifer; ---------------- I think some doxygen comments would be in order for this struct and its members. ================ Comment at: include-fixer/tool/ClangIncludeFixer.cpp:62 @@ -58,1 +61,3 @@ +cl::opt<bool> OuputHeaders( + "output-headers", ---------------- typo: Ouput http://reviews.llvm.org/D20621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits