bkramer added inline comments.

================
Comment at: include-fixer/tool/clang-include-fixer.py:84
@@ +83,3 @@
+    index = 1;
+    for header in lines[1:]:
+      choices_message += "&" + str(index) + header + "\n"
----------------
ioeric wrote:
> If there is only one candidate, it doesn't make sense to ask users to choose 
> it IMO. We can simply insert the header in this case.
> 
> And I think we should make users pick the correct header if there are 
> multiple candidates by default. What do you think, Ben? @bkramer
I agree, we should ask by default when there is more than one suggested header.


http://reviews.llvm.org/D20621



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to